You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/01/13 20:18:53 UTC
[GitHub] [myfaces] wtlucy commented on a change in pull request #127: MYFACES-4373: prefer SecureRandom for token generation 3.0.x
wtlucy commented on a change in pull request #127:
URL: https://github.com/apache/myfaces/pull/127#discussion_r556803559
##########
File path: impl/src/main/java/org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java
##########
@@ -133,11 +133,11 @@
* Adds a random key to the generated view state session token.
*/
@JSFWebConfigParam(since="2.1.9, 2.0.15", expectedValues="secureRandom, random",
- defaultValue="random", group="state")
+ defaultValue="secureRandom", group="state")
public static final String RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN_PARAM
= "org.apache.myfaces.RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN";
public static final String RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN_PARAM_DEFAULT =
- RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN_RANDOM;
+ RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN_SECURE_RANDOM;
Review comment:
Ah, good catch.. I'll do a new set of PRs to update the "Fallback" to SecureRandom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org