You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2021/03/31 14:21:39 UTC
[myfaces] branch master updated: MYFACES-4391: Disabled/Readonly
attributes render correct HTML
This is an automated email from the ASF dual-hosted git repository.
tandraschko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces.git
The following commit(s) were added to refs/heads/master by this push:
new a8f6ffe MYFACES-4391: Disabled/Readonly attributes render correct HTML
new cd2ae74 Merge pull request #193 from melloware/MYFACES-4391
a8f6ffe is described below
commit a8f6ffef2902631dd7d5470b574fd8b8a6210c71
Author: melloware <me...@gmail.com>
AuthorDate: Wed Mar 31 08:53:12 2021 -0400
MYFACES-4391: Disabled/Readonly attributes render correct HTML
---
.../apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java | 4 ++--
.../apache/myfaces/renderkit/html/base/HtmlCheckboxRendererBase.java | 2 +-
.../apache/myfaces/renderkit/html/base/HtmlInputFileRendererBase.java | 2 +-
.../org/apache/myfaces/renderkit/html/base/HtmlRadioRendererBase.java | 2 +-
.../apache/myfaces/renderkit/html/base/HtmlSecretRendererBase.java | 2 +-
.../myfaces/renderkit/html/base/HtmlSelectableRendererBase.java | 2 +-
.../apache/myfaces/renderkit/html/base/HtmlTextareaRendererBase.java | 2 +-
.../org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
index 1ce5143..a9aad96 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlButtonRendererBase.java
@@ -259,12 +259,12 @@ public class HtmlButtonRendererBase extends HtmlRenderer
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, JSFAttr.DISABLED_ATTR);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, JSFAttr.DISABLED_ATTR);
}
if (isReadonly(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.READONLY_ATTR, Boolean.TRUE, JSFAttr.READONLY_ATTR);
+ writer.writeAttribute(HTML.READONLY_ATTR, HTML.READONLY_ATTR, JSFAttr.READONLY_ATTR);
}
}
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlCheckboxRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlCheckboxRendererBase.java
index 269b947..817536d 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlCheckboxRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlCheckboxRendererBase.java
@@ -439,7 +439,7 @@ public class HtmlCheckboxRendererBase extends HtmlRenderer
}
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.endElement(HTML.INPUT_ELEM);
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlInputFileRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlInputFileRendererBase.java
index c1eef0d..3d609c6 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlInputFileRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlInputFileRendererBase.java
@@ -232,7 +232,7 @@ public class HtmlInputFileRendererBase extends HtmlRenderer
if (inputFile.isDisabled())
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (inputFile.isMultiple())
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlRadioRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlRadioRendererBase.java
index d4e4705..3bd9c3c 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlRadioRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlRadioRendererBase.java
@@ -508,7 +508,7 @@ public class HtmlRadioRendererBase extends HtmlRenderer
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.endElement(HTML.INPUT_ELEM);
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSecretRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSecretRendererBase.java
index bd06fb7..0ae8c8b 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSecretRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSecretRendererBase.java
@@ -168,7 +168,7 @@ public class HtmlSecretRendererBase extends HtmlRenderer
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (isAutocompleteOff(facesContext, uiComponent))
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSelectableRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSelectableRendererBase.java
index ab0585b..fcae4a7 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSelectableRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlSelectableRendererBase.java
@@ -147,7 +147,7 @@ public class HtmlSelectableRendererBase extends HtmlRenderer
if (disabled)
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (HtmlRendererUtils.isReadOnly(uiComponent))
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextareaRendererBase.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextareaRendererBase.java
index 7929088..548f27e 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextareaRendererBase.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextareaRendererBase.java
@@ -155,7 +155,7 @@ public class HtmlTextareaRendererBase extends HtmlRenderer
if (isDisabled(facesContext, uiComponent))
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
}
diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
index a4c33fc..48ac993 100644
--- a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
+++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/HtmlRendererUtils.java
@@ -439,7 +439,7 @@ public final class HtmlRendererUtils
if (disabled)
{
- writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+ writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
if (isReadOnly(uiComponent))