You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "soumyajit11 (via GitHub)" <gi...@apache.org> on 2023/10/14 06:58:41 UTC
[PR] Fixed logically dead code [trafficserver]
soumyajit11 opened a new pull request, #10611:
URL: https://github.com/apache/trafficserver/pull/10611
CID 1508856: Logically dead code #10432
In `access_control.cc`:
```cpp
197 size_t equalsign = kvp.find(_tokenConfig.kvDelimiter);
cond_cannot_single: Condition 18446744073709551615UL == equalsign, taking false branch. Now the value of equalsign cannot be equal to -1.
198 if (kvp.npos == equalsign) {
199 ERROR_OUT("invalid key-value-pair, missing key-value delimiter");
200 return _state = INVALID_SYNTAX;
201 }
202 StringView key = kvp.substr(0, equalsign);
cannot_single: At condition equalsign != 18446744073709551615UL, the value of equalsign cannot be equal to -1.
dead_error_condition: The condition equalsign != 18446744073709551615UL must be true.
CID 1508856 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: <temporary>.basic_string_vi....
203 StringView value = equalsign != kvp.npos ? kvp.substr(equalsign + 1) : "";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed logically dead code [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed logically dead code [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1763178155
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed logically dead code [trafficserver]
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1764877380
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed logically dead code [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1765352328
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed logically dead code [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1763224641
@soumyajit11 : @JosiahWI pointed out that your osx build should work once you rebase on top of latest master to pull in a fix for including openssl. Can you please rebase and push again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org