[GitHub] [spark] cloud-fan edited a comment on pull request #35574: [SPARK-38237][SQL][SS] Allow `HashPartitioning` to satisfy `ClusteredDistribution` only with full clustering keys

[GitBox <gi...@apache.org>]

cloud-fan edited a comment on pull request #35574:
URL: https://github.com/apache/spark/pull/35574#issuecomment-1048874149


   Sorry I have not read all the discussions in this PR, just to give my 2 cents if these points are not mentioned yet:
   1. It looks neater to have a special `Distribution` for this case (maybe add a boolean flag to `ClusteredDistribution`). Then we don't need to look at a runtime config in several `Partitioning` implementations, which can easily be missed when adding new `Partitioning` that can satisfy `ClusteredDistribution` in the future.
   2. It's more flexible to have a special `Distribution`, as we can use it only in some of the operators in a query plan, not all of them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org