You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/08 18:53:49 UTC
[GitHub] [incubator-yunikorn-k8shim] steinsgateted opened a new pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
steinsgateted opened a new pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364
### What is this PR for?
in k8shim:
save go build version and build date, and pass to core via scheduler-interface.
in core:
save k8shim's information and the time the scheduler was started.
then the Rest call pushes all information out.
in scheduler-interface:
the message RegisterResourceManagerRequest is extended with the build data.
add a map<string, string> buildInfo = 4 to the message.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-961
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037872028
Hi @yangwwei,
Thanks for the comment.
Sorry i made a mistake abount interface so wait for the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67b8eb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c912fbe79152192c1d3b8b3df96c666f72a0d162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c912fbe) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 67b8eb5 differs from pull request most recent head ed2a9a7. Consider uploading reports for the commit ed2a9a7 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c912fbe...ed2a9a7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037872028
Hi @yangwwei,
Thanks for the comment.
Sorry I made a mistake abount interface so wait for the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (31521db) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/b82620a9e9a1940cdb6ce01a91319979813f55bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b82620a) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 31521db differs from pull request most recent head 4eede92. Consider uploading reports for the commit 4eede92 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.44% 64.48% +0.03%
==========================================
Files 41 41
Lines 6146 6152 +6
==========================================
+ Hits 3961 3967 +6
+ Misses 2034 2032 -2
- Partials 151 153 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `66.35% <ø> (ø)` | |
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.43% <0.00%> (-5.24%)` | :arrow_down: |
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `72.58% <0.00%> (+0.55%)` | :arrow_up: |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `63.81% <0.00%> (+0.82%)` | :arrow_up: |
| [pkg/cache/nodes.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `78.28% <0.00%> (+1.12%)` | :arrow_up: |
| [pkg/common/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9ub2RlLmdv) | `85.71% <0.00%> (+14.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b82620a...4eede92](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1047441006
Sorry I made a mistake. Modified. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037872028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037755232
> Hi @yangwwei, Thanks for the comment. I run make lint with this message:
>
> ```
> pkg/shim/scheduler.go:254:3: unknown field `BuildInfo` in struct literal (typecheck)
> BuildInfo: buildInfoMap,
> ```
>
> I guess it's because in scheduler-interface hasn't updated build info yet.
That's correct. Can you please update the dependency in this PR? You can do this by go get command. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eede92) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/b82620a9e9a1940cdb6ce01a91319979813f55bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b82620a) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.44% 64.49% +0.04%
==========================================
Files 41 41
Lines 6146 6154 +8
==========================================
+ Hits 3961 3969 +8
Misses 2034 2034
Partials 151 151
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `66.35% <ø> (ø)` | |
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b82620a...4eede92](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1034251473
hi @steinsgateted there are some lint errors, could you please fix them? you can verify this locally with `make lint` before submitting the patch. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037872028
Hi @yangwwei,
Thanks for the comment.
Sorry, I made a mistake abount interface so wait for the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037872028
Hi @yangwwei,
Thanks for the comment.
Sorry I made a mistake abount interface so wait for the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7518f80) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/f0088a95c59005e0b5566b942c2e5f5de2d05b9f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0088a9) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7518f80 differs from pull request most recent head 67b8eb5. Consider uploading reports for the commit 67b8eb5 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `66.35% <ø> (ø)` | |
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f0088a9...67b8eb5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67b8eb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c912fbe79152192c1d3b8b3df96c666f72a0d162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c912fbe) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 67b8eb5 differs from pull request most recent head 31521db. Consider uploading reports for the commit 31521db to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c912fbe...31521db](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67b8eb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c912fbe79152192c1d3b8b3df96c666f72a0d162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c912fbe) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 67b8eb5 differs from pull request most recent head bb7c3bb. Consider uploading reports for the commit bb7c3bb to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c912fbe...bb7c3bb](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (31521db) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c912fbe79152192c1d3b8b3df96c666f72a0d162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c912fbe) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `66.35% <ø> (ø)` | |
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c912fbe...31521db](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1034593702
Hi @yangwwei,
Thanks for the comment.
I run make lint with this message:
```
pkg/shim/scheduler.go:254:3: unknown field `BuildInfo` in struct literal (typecheck)
BuildInfo: buildInfoMap,
```
I guess it's because in scheduler-interface hasn't updated build info yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#discussion_r809646938
##########
File path: pkg/shim/scheduler.go
##########
@@ -241,16 +242,23 @@ func (ss *KubernetesShim) doScheduling(e *fsm.Event) {
func (ss *KubernetesShim) registerShimLayer() error {
configuration := conf.GetSchedulerConf()
+
+ var buildInfoMap map[string]string
+ buildInfoMap["version"] = conf.Version
+ buildInfoMap["date"] = conf.Date
+
registerMessage := si.RegisterResourceManagerRequest{
RmID: configuration.ClusterID,
Version: configuration.ClusterVersion,
PolicyGroup: configuration.PolicyGroup,
+ BuildInfo: buildInfoMap,
}
log.Logger().Info("register RM to the scheduler",
zap.String("clusterID", configuration.ClusterID),
zap.String("clusterVersion", configuration.ClusterVersion),
- zap.String("policyGroup", configuration.PolicyGroup))
+ zap.String("policyGroup", configuration.PolicyGroup),
+ zap.String("buildInfo", fmt.Sprintf("%v", buildInfoMap)))
Review comment:
use the `zap.Any("buildInfo", buildInfoMap)` construct and let zap figure out how to log this.
##########
File path: pkg/conf/schedulerconf.go
##########
@@ -51,6 +51,9 @@ var once sync.Once
var configuration *SchedulerConf
var factory = initConfigs
+var Version string
+var Date string
+
Review comment:
Add a boolean flag to show that it is the plugin version or not. Set to true in the schedulerplugin/main.go file
##########
File path: pkg/shim/scheduler.go
##########
@@ -241,16 +242,23 @@ func (ss *KubernetesShim) doScheduling(e *fsm.Event) {
func (ss *KubernetesShim) registerShimLayer() error {
configuration := conf.GetSchedulerConf()
+
+ var buildInfoMap map[string]string
+ buildInfoMap["version"] = conf.Version
+ buildInfoMap["date"] = conf.Date
+
registerMessage := si.RegisterResourceManagerRequest{
RmID: configuration.ClusterID,
Version: configuration.ClusterVersion,
PolicyGroup: configuration.PolicyGroup,
+ BuildInfo: buildInfoMap,
Review comment:
This should be fixed as the SI reference has been updated already to include this
##########
File path: pkg/cmd/schedulerplugin/main.go
##########
@@ -40,6 +40,9 @@ func main() {
pluginconf.BuildVersion = version
pluginconf.BuildDate = date
+ conf.Version = version
+ conf.Date = date
+
Review comment:
These should replace the plugin config BuildVersion and BuildDate, those should be removed here and from the pluginconf code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] steinsgateted commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1032957654
It has not been completed, execute make test in k8sshim on the local side, there will be this error:
`fatal error: sync: RUnlock of unlocked RWMutex`
detailed:
```
2022-02-09T00:02:52.602+0800 INFO entrypoint/entrypoint.go:46 ServiceContext start all services
2022-02-09T00:02:52.606+0800 INFO entrypoint/entrypoint.go:93 ServiceContext start scheduling services
2022-02-09T00:02:52.607+0800 INFO entrypoint/entrypoint.go:110 creating InternalMetricsHistory
2022-02-09T00:02:52.607+0800 INFO entrypoint/entrypoint.go:117 ServiceContext start web application service
2022-02-09T00:02:52.610+0800 INFO webservice/webservice.go:71 web-app started {"port": 9080}
2022-02-09T00:02:52.610+0800 INFO log/logger.go:89 scheduler configuration, pretty print {"configs": "{\n \"schedulerName\": \"yunikorn\",\n \"clusterId\": \"my-kube-cluster\",\n \"clusterVersion\": \"0.1\",\n \"policyGroup\": \"queues\",\n \"schedulingIntervalSecond\": 1000000000,\n \"absoluteKubeConfigFilePath\": \"\",\n \"loggingLevel\": 0,\n \"logEncoding\": \"console\",\n \"logFilePath\": \"\",\n \"volumeBindTimeout\": 10000000000,\n \"testMode\": true,\n \"eventChannelCapacity\": 1048576,\n \"dispatchTimeout\": 300000000000,\n \"kubeQPS\": 1000,\n \"kubeBurst\": 1000,\n \"predicates\": \"\",\n \"operatorPlugins\": \"general,yunikorn-app\",\n \"enableConfigHotRefresh\": false,\n \"disableGangScheduling\": false,\n \"userLabelKey\": \"yunikorn.apache.org/username\"\n}"}
2022-02-09T00:02:52.610+0800 INFO appmgmt/appmgmt.go:50 Initializing new AppMgmt service
2022-02-09T00:02:52.611+0800 INFO dispatcher/dispatcher.go:80 Init dispatcher {"EventChannelCapacity": 1048576, "AsyncDispatchLimit": 104857, "DispatchTimeoutInSeconds": 300}
2022-02-09T00:02:52.611+0800 WARN appmgmt/appmgmt.go:133 App manager is not registered {"app manager name": "yunikorn-app"}
2022-02-09T00:02:52.611+0800 INFO dispatcher/dispatcher.go:183 starting the dispatcher
2022-02-09T00:02:52.612+0800 INFO cache/placeholder_manager.go:144 starting the PlaceholderManager
2022-02-09T00:02:52.612+0800 INFO shim/scheduler_mock_test.go:119 waiting for scheduler state {"expected": "Running", "actual": "New"}
fatal error: sync: RUnlock of unlocked RWMutex
goroutine 76 [running]:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1037755232
> Hi @yangwwei, Thanks for the comment. I run make lint with this message:
>
> ```
> pkg/shim/scheduler.go:254:3: unknown field `BuildInfo` in struct literal (typecheck)
> BuildInfo: buildInfoMap,
> ```
>
> I guess it's because in scheduler-interface hasn't updated build info yet.
That's correct. Can you please update the dependency in this PR? You can do this by go get command. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #364: [YUNIKORN-961] Expose build and version information in a REST call
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #364:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/364#issuecomment-1046009032
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#364](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67b8eb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/f0088a95c59005e0b5566b942c2e5f5de2d05b9f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0088a9) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 64.43% 64.48% +0.04%
==========================================
Files 41 41
Lines 6144 6152 +8
==========================================
+ Hits 3959 3967 +8
Misses 2032 2032
Partials 153 153
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/schedulerplugin/conf/pluginconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlcnBsdWdpbi9jb25mL3BsdWdpbmNvbmYuZ28=) | `86.36% <ø> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `77.60% <100.00%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f0088a9...67b8eb5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org