[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #49: [YUNIKORN-825] The protoc-gen-go version of si.pb.go should be v1.26.…

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #49:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/49#issuecomment-905245956


   > This will not fix the issue.
   > 
   > The commit for YUNIKORN-815 is dirty and has incorrect information in the `go.sum` file for the protobuf version.
   > 
   > There is also an issue with the way `go install` works as it was introduced in that change. It automatically upgrades the dependency for the grpc library to the latest version (currently 1.40).
   > This means that we now have might a moving target. A clean system build will not always build against the same version. Our build system cannot create a reproducible build anymore because the grpc version might just change when running that build.
   > @yangwwei @kingamarton
   
   Yes, I am working on this ... our SI build is broken, I am unable to update the dep for core and shim because of this. This is failing even before YUNIKORN-815.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org