[GitHub] [flink] TisonKun edited a comment on issue #10408: [FLINK-14992][client] Add job listener to execution environments

[GitBox <gi...@apache.org>]

TisonKun edited a comment on issue #10408: [FLINK-14992][client] Add job listener to execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561507505
 
 
   @zjffdu I implement `JobListener#onJobExecuted` called back on both execution(attach/detached). One more concern is about the thread. In the implementation I calls callbacks all on `CompletableFuture`'s default thread pool(mostly `ForkJoinPool`). It'd be better to check such decision with your user case. My concern is that user possibly calls expensive method in callback, if we set it as a constraint, it also makes sense we directly calls callback on current thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services