You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/03 04:14:39 UTC
[GitHub] [rocketmq] panzhi33 opened a new pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
panzhi33 opened a new pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#discussion_r741639310
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureTable.java
##########
@@ -31,14 +34,22 @@
public class RequestFutureTable {
Review comment:
It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#discussion_r741639310
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureTable.java
##########
@@ -31,14 +34,22 @@
public class RequestFutureTable {
Review comment:
It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#issuecomment-959118339
[](https://coveralls.io/builds/43982673)
Coverage increased (+0.006%) to 54.534% when pulling **da33aa90fabcfbcd2fe55cd85a12bc2b434e7658 on panzhi33:master** into **2385f0446832d4e799c16d280a88cafc548fab39 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#issuecomment-959118339
[](https://coveralls.io/builds/44004805)
Coverage increased (+0.009%) to 54.537% when pulling **3d7226c18a9fa01c44728f99ad9a4b0774dcacbc on panzhi33:master** into **2385f0446832d4e799c16d280a88cafc548fab39 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#issuecomment-959118339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#discussion_r741639310
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureTable.java
##########
@@ -31,14 +34,22 @@
public class RequestFutureTable {
Review comment:
It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#discussion_r741639310
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureTable.java
##########
@@ -31,14 +34,22 @@
public class RequestFutureTable {
Review comment:
It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3454: [ISSUE #3453]Producer cannot shutdown completely
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3454:
URL: https://github.com/apache/rocketmq/pull/3454#issuecomment-959118339
[](https://coveralls.io/builds/43982673)
Coverage increased (+0.006%) to 54.534% when pulling **da33aa90fabcfbcd2fe55cd85a12bc2b434e7658 on panzhi33:master** into **2385f0446832d4e799c16d280a88cafc548fab39 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org