[GitHub] [arrow] wgtmac commented on a diff in pull request #36192: PARQUET-2316:[C++]: Allow partial prebuffer in parquet FileReader

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #36192:
URL: https://github.com/apache/arrow/pull/36192#discussion_r1236200894


##########
cpp/src/parquet/file_reader.cc:
##########
@@ -268,6 +272,7 @@ class SerializedRowGroup : public RowGroupReader::Contents {
   std::unique_ptr<RowGroupMetaData> row_group_metadata_;
   ReaderProperties properties_;
   int row_group_ordinal_;
+  std::unordered_set<int>& prebuffered_column_chunks_;

Review Comment:
   IMO, this would be better to use `const std::unordered_set<int>`, without reference.



##########
cpp/src/parquet/file_reader.cc:
##########
@@ -178,13 +179,15 @@ class SerializedRowGroup : public RowGroupReader::Contents {
                      std::shared_ptr<::arrow::io::internal::ReadRangeCache> cached_source,
                      int64_t source_size, FileMetaData* file_metadata,
                      int row_group_number, const ReaderProperties& props,
+                     std::unordered_set<int>& prebuffered_column_chunks,

Review Comment:
   `const std::unordered_set<int>&` or `std::unordered_set<int>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org