You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/21 04:03:20 UTC

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #1917: Fix max and min decimal for max precision

liukun4515 commented on code in PR #1917:
URL: https://github.com/apache/arrow-rs/pull/1917#discussion_r902141763


##########
arrow/src/datatypes/datatype.rs:
##########
@@ -238,7 +238,7 @@ pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [
     99999999999999999999999999999999999,
     999999999999999999999999999999999999,
     9999999999999999999999999999999999999,
-    170141183460469231731687303715884105727,

Review Comment:
   @viirya 
   This is a mistake when i create this table and use the max or min of i128.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org