[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8650: Fixing variable conflicts between Superset and Boot(swatch/strap)

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8650: Fixing variable conflicts between Superset and Boot(swatch/strap)
URL: https://github.com/apache/incubator-superset/pull/8650#discussion_r351411335
 
 

 ##########
 File path: superset/assets/stylesheets/less/cosmo/variables.less
 ##########
 @@ -21,15 +21,15 @@
 // --------------------------------------------------
 
 
-//== Colors
+// == Colors
 //
-//## Gray and brand colors for use across Bootstrap.
+// ## Gray and brand colors for use across Bootstrap.
 
 @gray-base:              #000;
 @gray-darker:            lighten(@gray-base, 13.5%);
 @gray-dark:              lighten(@gray-base, 20%);
-@gray:                   lighten(@gray-base, 33.5%);
-@gray-light:             lighten(@gray-base, 70%);
+@bs-gray:                   lighten(@gray-base, 33.5%);
+@bs-gray-light:             lighten(@gray-base, 70%);
 
 Review comment:
   nit: tab miss aligned

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org