You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/25 21:08:02 UTC
[GitHub] [incubator-mxnet] andrei5055 opened a new pull request #18792: [MXNET-17951] Argsort for fp16
andrei5055 opened a new pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792
## Make TopK functions working with fp16 arguments ##
1. TopK functions (sort, argsort) can work with the fp16 tensors.
2. On GPU the switch from `cub::DeviceRadixSort` to `cub::DeviceSegmentedRadixSort` reduces tree `mxnet::op::SortByKey` calls to one such call in TopKSort function.
## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- [x] Code is well-documented:
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Testing TopK functions wit the fp16 tensors ids done
a) in `/tests/python/unittest/test_operator.py`:
```
def test_order():
. . .
for dtype in [np.float16, np.float32, np.float64]:
```
b) in `/tests/python/unittest/test_ndarray.py`
```
def test_order():
. . .
tested_types = [np.int32, np.int64, np.float16, np.float32, np.float64]
for dtype in tested_types:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678618218
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678618210
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678606744
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-663906264
Hey @andrei5055 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, windows-gpu, edge, unix-gpu, centos-cpu, miscellaneous, unix-cpu, clang, centos-gpu, website, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-680404761
@ptrendx would you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-663910295
lint needs fixing. you can test it locally with `ci/build.py -R --docker-registry mxnetci --platform ubuntu_cpu --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh sanity_check` (docker and docker-compose required)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-677715257
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678509955
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678588122
Jenkins CI successfully triggered : [unix-cpu, miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-677715315
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-676608423
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678510089
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] andrei5055 commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
andrei5055 commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-678588110
@mxnet-bot run ci [unix-cpu, miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18792: [MXNET-17951] Argsort for fp16
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18792:
URL: https://github.com/apache/incubator-mxnet/pull/18792#issuecomment-676608485
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org