You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/29 05:34:44 UTC

[GitHub] [kafka] abbccdda commented on pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

abbccdda commented on pull request #8941:
URL: https://github.com/apache/kafka/pull/8941#issuecomment-650917644


   Thanks for the refactoring. TBH, I'm not fully convinced this refactoring is simplifying the logical connections between internal classes. What is the goal for this refactoring? In terms of complexity, we further adds up the interaction between `OffsetManageCoordinator` and `ConsumerCoordinator`, and the total LOC is not reduced either. If we are just moving a group of methods to another class, the migration of test cases, interaction logic, etc, are all the non-trivial review costs incurred. It would be better to clarify the gain here before fully investing on making this change. cc @guozhangwang @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org