You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/01/17 21:41:20 UTC
svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Author: markt
Date: Thu Jan 17 20:41:19 2013
New Revision: 1434905
URL: http://svn.apache.org/viewvc?rev=1434905&view=rev
Log:
Trailing whitespace police
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/SSL.java?rev=1434905&r1=1434904&r2=1434905&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/jni/SSL.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/SSL.java Thu Jan 17 20:41:19 2013
@@ -341,14 +341,14 @@ public final class SSL {
/**
* Return true if all the requested SSL_OP_* are supported by OpenSSL.
- *
+ *
* <i>Note that for versions of tcnative < 1.1.25, this method will
* return <code>true</code> if and only if <code>op</code>=
* {@link #SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION} and tcnative
* supports that flag.</i>
*
* @param Bitwise-OR of all SSL_OP_* to test.
- *
+ *
* @return true if all SSL_OP_* are supported by OpenSSL library.
*/
public static native boolean hasOp(int op);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
RE: svn commit: r1434905 -
/tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by "Caldarale, Charles R" <Ch...@unisys.com>.
> From: Mark Thomas [mailto:markt@apache.org]
> Subject: Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
> I did see a "no unnecessary brackets" rule that I think Chuck would love.
My favorite hate is multi-line if statements without braces. Can't count the number of times I've had to fix code where someone dropped an additional statement in between the if and the original target (including in the CIFS client module in Linux).
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by Mark Thomas <ma...@apache.org>.
On 17/01/2013 22:49, Christopher Schultz wrote:
> On 1/17/13 4:28 PM, Mark Thomas wrote:
<snip/>
>> I have Checkstyle configured in Eclipse and it nags me if it
>> finds any trailing whitespace (usually from other commits after
>> an svn up).
>
> I'll work on getting that configured, too.
You might want to add FindBugs to that list too - at least for trunk.
As of earlier today trunk was completely clean of Eclipse, Checkstyle
and FindBugs problems. It should be easy to spot an issue with new
code from this point forward as there is no noise to hide it.
I'm not sure what I am going to do in those odd five minutes where I
used to just fix a handful of warnings. Maybe I'll have to find some
more rules to enable :) I did see a "no unnecessary brackets" rule
that I think Chuck would love.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 1/17/13 4:28 PM, Mark Thomas wrote:
> On 17/01/2013 21:07, Christopher Schultz wrote:
>> Mark,
>>
>> On 1/17/13 3:41 PM, markt@apache.org wrote:
>>> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision:
>>> 1434905
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log:
>>> Trailing whitespace police
>>
>> Do you have any idea how to get Eclipse to stop adding that crap?
>> It's obviously impossible to see and running find-and-replace for
>> trailing spaces is a pain.
>
> Preferences > Java > Editor > Save Actions > Additional Actions >
> Configure > Code Organizing
>
> Easy. Not.
;)
> I have it set to all lines for trunk and 7.0.x and disabled for 6.0.x
Okay, I have the same on trunk, now, too. So you should get fewer
spurious spaces from me, now.
>> Do you just end up running checkstyle before a commit to make
>> sure?
>
> I have Checkstyle configured in Eclipse and it nags me if it finds any
> trailing whitespace (usually from other commits after an svn up).
I'll work on getting that configured, too.
Thanks,
-chris
Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by Mark Thomas <ma...@apache.org>.
On 17/01/2013 21:07, Christopher Schultz wrote:
> Mark,
>
> On 1/17/13 3:41 PM, markt@apache.org wrote:
>> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision:
>> 1434905
>>
>> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log:
>> Trailing whitespace police
>
> Do you have any idea how to get Eclipse to stop adding that crap?
> It's obviously impossible to see and running find-and-replace for
> trailing spaces is a pain.
Preferences > Java > Editor > Save Actions > Additional Actions >
Configure > Code Organizing
Easy. Not.
I have it set to all lines for trunk and 7.0.x and disabled for 6.0.x
> Do you just end up running checkstyle before a commit to make
> sure?
I have Checkstyle configured in Eclipse and it nags me if it finds any
trailing whitespace (usually from other commits after an svn up).
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
RE: svn commit: r1434905 -
/tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by "Caldarale, Charles R" <Ch...@unisys.com>.
> From: Christopher Schultz [mailto:chris@christopherschultz.net]
> Subject: Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
> Do you have any idea how to get Eclipse to stop adding that crap? It's
> obviously impossible to see and running find-and-replace for trailing
> spaces is a pain.
The Eclipse C/C++ editor allows you to trim trailing whitespace on a save, but it doesn't look like the Java editor includes that. A simple regex will do it, but you have to remember to run it. It appears that all the editors can be configured to display a symbol for whitespace, but not just trailing areas.
There's a reason I use jEdit...
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 1/17/13 3:41 PM, markt@apache.org wrote:
> Author: markt
> Date: Thu Jan 17 20:41:19 2013
> New Revision: 1434905
>
> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev
> Log:
> Trailing whitespace police
Do you have any idea how to get Eclipse to stop adding that crap? It's
obviously impossible to see and running find-and-replace for trailing
spaces is a pain.
Do you just end up running checkstyle before a commit to make sure?
-chris