You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/06 19:40:07 UTC

Review Request 22311: Added virtual destructor to Operation base class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22311/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-1459
    https://issues.apache.org/jira/browse/MESOS-1459


Repository: mesos-git


Description
-------

delete is called on an Owned<Operation> which is undefined behaviour without a virtual destructor.


Diffs
-----

  src/launcher/launcher.hpp 551b445d5e27ddb4cfa23e4a6a8de91388ab507e 

Diff: https://reviews.apache.org/r/22311/diff/


Testing
-------

make check


Thanks,

Dominic Hamon

Re: Review Request 22311: Added virtual destructor to Operation base class

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22311/#review44935
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On June 6, 2014, 5:40 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22311/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 5:40 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-1459
>     https://issues.apache.org/jira/browse/MESOS-1459
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> delete is called on an Owned<Operation> which is undefined behaviour without a virtual destructor.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.hpp 551b445d5e27ddb4cfa23e4a6a8de91388ab507e 
> 
> Diff: https://reviews.apache.org/r/22311/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>