You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/06/02 06:48:00 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #2134: IGNITE-19596 Partition creation fails with NSFE
tkalkirill opened a new pull request, #2134:
URL: https://github.com/apache/ignite-3/pull/2134
https://issues.apache.org/jira/browse/IGNITE-19596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill merged pull request #2134: IGNITE-19596 Partition creation fails with NSFE
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #2134:
URL: https://github.com/apache/ignite-3/pull/2134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2134: IGNITE-19596 Partition creation fails with NSFE
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2134:
URL: https://github.com/apache/ignite-3/pull/2134#discussion_r1214215024
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManagerTest.java:
##########
@@ -440,13 +449,68 @@ void testFullyRemovePartitionOnStart() throws Exception {
);
}
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 4, 10, 25, 50})
Review Comment:
Let's add a sane time out (like `@Timeout(value = 1, unit = MINUTE)`) just in case as racers use potentially infinite loops (if something gets broken in the future, they could hang forever)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2134: IGNITE-19596 Partition creation fails with NSFE
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2134:
URL: https://github.com/apache/ignite-3/pull/2134#discussion_r1214217015
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManagerTest.java:
##########
@@ -440,13 +449,68 @@ void testFullyRemovePartitionOnStart() throws Exception {
);
}
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 4, 10, 25, 50})
Review Comment:
Why not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org