You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/15 19:35:20 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
donnerpeter opened a new pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
If an inflected form is listed in the dictionary like KEEPCASE, its other variations should be considered misspelled, even if affix removal would result in a non-KEEPCASE root
# Solution
Move case check to the `RootProcessor` and make the spellchecking's one stop if it isn't satisfied. Disregard `KEEPCASE` in `Stemmer` to make it more consistent with "hunspell -s", move the code to `Hunspell`
# Tests
`keepcase` appended with the scenario in question. `forbiddenword` appended as well, with a non-unit-tested case that started to fail on a real corpus after some intermediate version of the keepcase change.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374#discussion_r576391510
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/forbiddenword.dic
##########
@@ -8,4 +8,6 @@ kg
Kg/X
KG/X
cm
-Cm/X
\ No newline at end of file
+Cm/X
+SIPS/X
Review comment:
Something from Dutch dictionaties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374#discussion_r576390774
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java
##########
@@ -165,6 +167,29 @@ private boolean checkCompounds(char[] wordChars, int length, WordCase originalCa
return result[0];
}
+ private boolean acceptCase(WordCase originalCase, int entryId, CharsRef root) {
Review comment:
Moved from Stemmer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374#discussion_r576391335
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestKeepCase.java
##########
@@ -34,17 +34,22 @@ public void testPossibilities() {
assertStemsTo("DRINKS", "drink");
assertStemsTo("walk", "walk");
assertStemsTo("walks", "walk");
- assertStemsTo("Walk");
- assertStemsTo("Walks");
- assertStemsTo("WALKS");
+ assertStemsTo("Walk", "walk");
Review comment:
More consistency with cmd line Hunspell. Hopefully it's fine for Lucene as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374#discussion_r576390971
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -237,19 +236,11 @@ int findSS(int start) {
}
boolean doStem(
- char[] word,
- int offset,
- int length,
- WordCase originalCase,
Review comment:
We now don't need to pass this case everywhere, yay!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2374: LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2374:
URL: https://github.com/apache/lucene-solr/pull/2374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org