You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/08/23 14:27:29 UTC

[GitHub] [phoenix] richardantal commented on a diff in pull request #1491: PHOENIX-6774 Enable code coverage reporting to SonarQube in Phoenix

richardantal commented on code in PR #1491:
URL: https://github.com/apache/phoenix/pull/1491#discussion_r952701222


##########
pom.xml:
##########
@@ -1882,6 +1883,27 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>sonar</id>

Review Comment:
   Bit late but this profile should be called as 'codecoverage'
   Or something else but consistent with the readme and most importantly the run-coverage.sh file.
   Please create an addendum for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org