You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangchengming601 (via GitHub)" <gi...@apache.org> on 2023/05/08 03:10:32 UTC
[GitHub] [incubator-seatunnel] zhangchengming601 opened a new pull request, #4715: [Doc][Redshift] Add JDBC's Redshift source and sink doc
zhangchengming601 opened a new pull request, #4715:
URL: https://github.com/apache/incubator-seatunnel/pull/4715
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on pull request #4715: [Doc][Redshift] Add JDBC's Redshift source and sink doc
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4715:
URL: https://github.com/apache/incubator-seatunnel/pull/4715#issuecomment-1539305716
> > Bosses, I've added some reviews to help us get started @Hisoka-X
>
> Hi @zhilinli123 , I don't get it. What should I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4715: [Doc][Redshift] Add JDBC's Redshift source and sink doc
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4715:
URL: https://github.com/apache/incubator-seatunnel/pull/4715#issuecomment-1539257883
> Bosses, I've added some reviews to help us get started @Hisoka-X
Hi @zhilinli123 , I don't get it. What should I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhilinli123 commented on pull request #4715: [Doc][Redshift] Add JDBC's Redshift source and sink doc
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4715:
URL: https://github.com/apache/incubator-seatunnel/pull/4715#issuecomment-1538473122
Bosses, I've added some reviews to help us get started
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #4715: [Doc][Redshift] Add JDBC's Redshift source and sink doc
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on PR #4715:
URL: https://github.com/apache/incubator-seatunnel/pull/4715#issuecomment-1549773202
> > > Bosses, I've added some reviews to help us get started @Hisoka-X
> >
> >
> > Hi @zhilinli123 , I don't get it. What should I do?
>
> <img alt="image" width="1175" src="https://user-images.githubusercontent.com/76689593/236980157-abc51dbf-2fcf-453a-8aae-e0e988fb6a3f.png">
>
> Display pending It's not clear if it needs to be turned on by someone with access
This way you can submit your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Doc][Redshift] Add JDBC's Redshift source and sink doc [seatunnel]
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4715:
URL: https://github.com/apache/seatunnel/pull/4715#issuecomment-2071353455
@zhangchengming601 hi please fix ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org