You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/21 12:55:35 UTC
[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2576: xtensa/esp32: Added watcher defconfig
saramonteiro opened a new pull request #2576:
URL: https://github.com/apache/incubator-nuttx/pull/2576
## Summary
Adds a ready defconfig to use watcher example merged in with https://github.com/apache/incubator-nuttx-apps/pull/516.
## Impact
N/A
## Testing
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2576: Added watcher defconfig
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on a change in pull request #2576:
URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546824145
##########
File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig
##########
@@ -0,0 +1,54 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-core"
+CONFIG_ARCH_BOARD_ESP32CORE=y
Review comment:
I did the necessary changes and ran make and It's ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2576: Added watcher defconfig
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2576:
URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546773450
##########
File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig
##########
@@ -0,0 +1,54 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-core"
+CONFIG_ARCH_BOARD_ESP32CORE=y
Review comment:
Actually the whole file needs to be renamed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2576: Added watcher defconfig
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2576:
URL: https://github.com/apache/incubator-nuttx/pull/2576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2576: Added watcher defconfig
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2576:
URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546770338
##########
File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig
##########
@@ -0,0 +1,54 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-core"
+CONFIG_ARCH_BOARD_ESP32CORE=y
Review comment:
Update to esp32-devkitc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org