You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/22 03:07:23 UTC

[GitHub] [hudi] wangxianghu commented on a change in pull request #1984: [HUDI-1200] Fix NullPointerException, CustomKeyGenerator does not work

wangxianghu commented on a change in pull request #1984:
URL: https://github.com/apache/hudi/pull/1984#discussion_r475038373



##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/KeyGenerator.java
##########
@@ -41,7 +41,7 @@
   private static final String STRUCT_NAME = "hoodieRowTopLevelField";
   private static final String NAMESPACE = "hoodieRow";
 
-  protected transient TypedProperties config;
+  protected  TypedProperties config;

Review comment:
       > This is intended to be transient so that we don't serialize config in KeyGenerator s. Lets keep it that way. Since the issue is specifically with CustomKeyGenerator we should resolve there.
   
   Hi @bhasudha , CustomKeyGenerator extends KeyGenerator, maybe this NPE is caused by the config(lost in the process of serialization) in KeyGenerator. @liujinhui1994 is that what you mean?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org