You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:10:54 UTC
[GitHub] [incubator-eventmesh] chenqinyuan opened a new issue, #1905: Possible null pointer dereference due to return value of called method [WebHookProtocolAdaptor]
chenqinyuan opened a new issue, #1905:
URL: https://github.com/apache/incubator-eventmesh/issues/1905
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
`
@Override
public ProtocolTransportObject fromCloudEvent(CloudEvent cloudEvent) throws ProtocolHandleException {
final HttpEventWrapper httpEventWrapper = new HttpEventWrapper();
Map<String, Object> sysHeaderMap = new HashMap<>();
// ce attributes
Set<String> attributeNames = cloudEvent.getAttributeNames();
// ce extensions
Set<String> extensionNames = cloudEvent.getExtensionNames();
for (String attributeName : attributeNames) {
sysHeaderMap.put(attributeName, cloudEvent.getAttribute(attributeName));
}
for (String extensionName : extensionNames) {
sysHeaderMap.put(extensionName, cloudEvent.getExtension(extensionName));
}
sysHeaderMap.put("cloudEventId", cloudEvent.getId());
sysHeaderMap.put("cloudEventName", cloudEvent.getSubject());
sysHeaderMap.put("cloudEventSource", cloudEvent.getSource().toString());
sysHeaderMap.put("type", cloudEvent.getType());
httpEventWrapper.setSysHeaderMap(sysHeaderMap);
httpEventWrapper.setBody(cloudEvent.getData().toBytes());
return httpEventWrapper;
}
`
located at:
org/apache/eventmesh/protocol/webhook/WebHookProtocolAdaptor.java line78
Add NPE to check for exceptions.
### Describe the solution you'd like
`
@Override
public ProtocolTransportObject fromCloudEvent(CloudEvent cloudEvent) throws ProtocolHandleException {
final HttpEventWrapper httpEventWrapper = new HttpEventWrapper();
Map<String, Object> sysHeaderMap = new HashMap<>();
// ce attributes
Set<String> attributeNames = cloudEvent.getAttributeNames();
// ce extensions
Set<String> extensionNames = cloudEvent.getExtensionNames();
for (String attributeName : attributeNames) {
sysHeaderMap.put(attributeName, cloudEvent.getAttribute(attributeName));
}
for (String extensionName : extensionNames) {
sysHeaderMap.put(extensionName, cloudEvent.getExtension(extensionName));
}
sysHeaderMap.put("cloudEventId", cloudEvent.getId());
sysHeaderMap.put("cloudEventName", cloudEvent.getSubject());
sysHeaderMap.put("cloudEventSource", cloudEvent.getSource().toString());
sysHeaderMap.put("type", cloudEvent.getType());
httpEventWrapper.setSysHeaderMap(sysHeaderMap);
if(cloudEvent.getData() != null){
httpEventWrapper.setBody(cloudEvent.getData().toBytes());
}
return httpEventWrapper;
}
`
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #1905: Possible null pointer dereference due to return value of called method [WebHookProtocolAdaptor]
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1905: Possible null pointer dereference due to return value of called method [WebHookProtocolAdaptor]
URL: https://github.com/apache/incubator-eventmesh/issues/1905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #1905: Possible null pointer dereference due to return value of called method [WebHookProtocolAdaptor]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1905:
URL: https://github.com/apache/incubator-eventmesh/issues/1905#issuecomment-1291951245
Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D
Please make sure to include all the relevant context.
We will be here shortly.
If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description |Subscribe |Unsubscribe|Archive
| ---- | ---- |---- | ---- | ---- |
|Users |User support and questions mailing list| [Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
|Development |Development related discussions| [Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
|Commits |All commits to repositories| [Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org