You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/03/01 06:34:15 UTC

Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57179/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20131
    https://issues.apache.org/jira/browse/AMBARI-20131


Repository: ambari


Description
-------

Fixed by creating the tabs observer after tabs are initializes


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 74de3b7 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js 2e937e5 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 9fd8286 
  contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js 7c59f40 
  contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js e77ef7f 


Diff: https://reviews.apache.org/r/57179/diff/1/


Testing
-------

Manual Testing


Thanks,

Padma Priya N


Re: Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57179/#review167210
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On March 1, 2017, 6:34 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57179/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 6:34 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20131
>     https://issues.apache.org/jira/browse/AMBARI-20131
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed by creating the tabs observer after tabs are initializes
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 74de3b7 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js 2e937e5 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 9fd8286 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js 7c59f40 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js e77ef7f 
> 
> 
> Diff: https://reviews.apache.org/r/57179/diff/1/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57179/#review167262
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On March 1, 2017, 6:34 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57179/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 6:34 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20131
>     https://issues.apache.org/jira/browse/AMBARI-20131
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed by creating the tabs observer after tabs are initializes
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 74de3b7 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js 2e937e5 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 9fd8286 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js 7c59f40 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js e77ef7f 
> 
> 
> Diff: https://reviews.apache.org/r/57179/diff/1/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>