You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mindlesscloud (via GitHub)" <gi...@apache.org> on 2023/06/26 04:56:27 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #5570: fix: stuck tasks
mindlesscloud opened a new pull request, #5570:
URL: https://github.com/apache/incubator-devlake/pull/5570
### Summary
Fix #5569, This bug is due to not being careful enough with the use of Mutex
### Does this close any open issues?
Closes #5569
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5570: fix: stuck tasks
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #5570:
URL: https://github.com/apache/incubator-devlake/pull/5570#discussion_r1241571016
##########
backend/helpers/pluginhelper/api/batch_save.go:
##########
@@ -102,17 +102,21 @@ func (c *BatchSave) Add(slot interface{}) errors.Error {
c.current++
// flush out into database if max outed
if c.current == c.size {
- return c.Flush()
+ return c.flushWithoutLocking()
} else if c.current%100 == 0 {
c.log.Debug("batch save current: %d", c.current)
}
return nil
}
Review Comment:
the comments should say "maxed out" not "max outed"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5570: fix: stuck tasks
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #5570:
URL: https://github.com/apache/incubator-devlake/pull/5570#discussion_r1241571472
##########
backend/helpers/pluginhelper/api/batch_save.go:
##########
@@ -132,8 +136,10 @@ func (c *BatchSave) Flush() errors.Error {
Review Comment:
"flush" not "flash"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #5570: fix: stuck tasks
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #5570:
URL: https://github.com/apache/incubator-devlake/pull/5570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org