You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jonathan Bardin (JIRA)" <ji...@apache.org> on 2010/04/20 19:02:51 UTC
[jira] Created: (FELIX-2292) Uprage to jetty 7.0 (org.eclipse.jetty
7.0.2v20100331)
Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
------------------------------------------------------
Key: FELIX-2292
URL: https://issues.apache.org/jira/browse/FELIX-2292
Project: Felix
Issue Type: Improvement
Components: HTTP Service
Reporter: Jonathan Bardin
Hi,
This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
The patch is following.
Regards,
Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2292) Uprage to jetty 7.0 (org.eclipse.jetty
7.0.2v20100331)
Posted by "Jonathan Bardin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Bardin updated FELIX-2292:
-----------------------------------
Attachment: jetty7.patch
The patch.
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2292) Uprage to jetty 7.0 (org.eclipse.jetty
7.0.2v20100331)
Posted by "Jonathan Bardin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Bardin updated FELIX-2292:
-----------------------------------
Attachment: jetty7GoodFormat.patch
The patch is now in the good format, sorry for this.
The migration from Jetty 6 to Jetty 7 was pretty straightforward, there is no changes in the behavior. It has been tested with java 6 and 5.
Thank you,
Jonathan
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859545#action_12859545 ]
Sten Roger Sandvik commented on FELIX-2292:
-------------------------------------------
Thanks for the patch. Should this patch be applied to a major (2.1.0) or minor (2.0.6) version of the service? What do you guys think?
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2292) Uprage to jetty 7.0 (org.eclipse.jetty
7.0.2v20100331)
Posted by "Sten Roger Sandvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sten Roger Sandvik updated FELIX-2292:
--------------------------------------
Fix Version/s: http-2.1.0
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Fix For: http-2.1.0
>
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Rob Walker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859673#action_12859673 ]
Rob Walker commented on FELIX-2292:
-----------------------------------
Personally, I'd say it was a significant change and hence major seems more appropriate
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Rob Walker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863779#action_12863779 ]
Rob Walker commented on FELIX-2292:
-----------------------------------
Ok - both the new (jetty) and old (http.jetty) implementations seem to work fine on 6.1.24, so as an interim step prior to moving to jetty 7 I'll commit those changes.
I guess the question then is do we release the current snapshot (2.0.5) prior to starting the 2.1 version on jetty 7. My view would be yes, so that we have a released "final" jetty 6 version on the latest current jetty6 for anyone who doesn't want to go to jetty 7 yet.
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Fix For: http-2.1.0
>
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Clement Escoffier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859706#action_12859706 ]
Clement Escoffier commented on FELIX-2292:
------------------------------------------
It's a major change for me too. So, I would prefer doing a 2.1 release for this change.
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859699#action_12859699 ]
Felix Meschberger commented on FELIX-2292:
------------------------------------------
I agree, that this is a major change, thus a new minor number (thus 2.1) (2.0.6 would be a micro or patch number increase).
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Rob Walker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863712#action_12863712 ]
Rob Walker commented on FELIX-2292:
-----------------------------------
Thinking about this some more - I wonder if there is anyone who would prefer a later Jetty6 release prior to the Jetty7 one?
If so, we could do a stepwise upgrade from 6.1.21 to the latest Jetty6 (6.1.24) under say 2.0.6-SNAPSHOT prior to committing the jetty 7 changes under a 2.1.0-SNAPSHOT.
Obviously this is something of a half-solution - since we're still making an actual cutover point using this approach, albeit at the "current latest Jetty6" version. If anyone had longer term interests in staying on Jetty6, we'd need to figure a way to have parallel options e.g. move the current code to a jetty6 package for those wanting that version.
I doubt it's much of an issue - just something to consider
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Fix For: http-2.1.0
>
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Rob Walker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863697#action_12863697 ]
Rob Walker commented on FELIX-2292:
-----------------------------------
I'm working in this area at present, so if everyone is happy we go for this I'm happy to apply Jonathan's patch and also update the POM version to 2.1-SNAPSHOT (or should that be 2.1.0-SNAPSHOT?)
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Fix For: http-2.1.0
>
> Attachments: jetty7.patch, jetty7GoodFormat.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2292) Uprage to jetty 7.0
(org.eclipse.jetty 7.0.2v20100331)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859239#action_12859239 ]
Felix Meschberger commented on FELIX-2292:
------------------------------------------
Thanks for providing the patch.
I would like to know whether there are things to consider when migrating from Jetty 6 to Jetty 7 in terms of system requirements, Java requirements, changes in behaviour ... Thanks.
Could you please fix the formatting of your patch (we place opening brackets { on the next line not on the same line; the ASF license header has been reformatted; we don't have tabs in the pom.xml). Thanks alot !
> Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)
> ------------------------------------------------------
>
> Key: FELIX-2292
> URL: https://issues.apache.org/jira/browse/FELIX-2292
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
> Reporter: Jonathan Bardin
> Attachments: jetty7.patch
>
>
> Hi,
> This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
> The patch is following.
> Regards,
> Jonathan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.