You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Arnaud Launay <as...@launay.org> on 2017/01/03 17:59:04 UTC
[PATCH 2/4] BIGTOP-2649: BIGTOP_JDK needs to go down to scripts
---
packages.gradle | 1 +
1 file changed, 1 insertion(+)
diff --git a/packages.gradle b/packages.gradle
index c00efc6..f6b8543 100644
--- a/packages.gradle
+++ b/packages.gradle
@@ -302,6 +302,7 @@ def genTasks = { target ->
--preserve-envvar MAVEN3_HOME \
--preserve-envvar MAVEN_OPTS \
--preserve-envvar JAVA_HOME \
+--preserve-envvar BIGTOP_JDK \
--set-envvar=HADOOP_VERSION=$HADOOP_VERSION \
--set-envvar=${toOldStyleName(target)}_BASE_VERSION=$BASE_VERSION \
--set-envvar=${toOldStyleName(target)}_VERSION=$PKG_VERSION \
--
2.1.4
Re: [PATCH 2/4] BIGTOP-2649: BIGTOP_JDK needs to go down to scripts
Posted by Arnaud Launay <as...@launay.org>.
Le Thu, Jan 05, 2017 at 11:21:31AM +0100, Olaf Flebbe a écrit:
> this totally makes sense! I like it.
Given nobody seems to object, I pushed the patches to Jira:
https://issues.apache.org/jira/browse/BIGTOP-2649
Arnaud.
Re: [PATCH 2/4] BIGTOP-2649: BIGTOP_JDK needs to go down to scripts
Posted by Olaf Flebbe <of...@oflebbe.de>.
Arnaud,
this totally makes sense! I like it.
Olaf
Am 05.01.2017 um 11:01 schrieb Arnaud Launay:
> Le Wed, Jan 04, 2017 at 05:09:17PM -0800, Konstantin Boudnik a crit:
>> Any chance this could be attached to a JIRA in the form of a patch?
>
> Yes it will, I was just hoping for some comments like "please
> modify this" or "this is good / this is not" before putting them
> on jira :)
>
> Arnaud.
>
Re: [PATCH 2/4] BIGTOP-2649: BIGTOP_JDK needs to go down to scripts
Posted by Arnaud Launay <as...@launay.org>.
Le Wed, Jan 04, 2017 at 05:09:17PM -0800, Konstantin Boudnik a écrit:
> Any chance this could be attached to a JIRA in the form of a patch?
Yes it will, I was just hoping for some comments like "please
modify this" or "this is good / this is not" before putting them
on jira :)
Arnaud.
Re: [PATCH 2/4] BIGTOP-2649: BIGTOP_JDK needs to go down to scripts
Posted by Konstantin Boudnik <co...@apache.org>.
Any chance this could be attached to a JIRA in the form of a patch?
Thanks,
Cos
On Tue, Jan 03, 2017 at 06:59PM, Arnaud Launay wrote:
> ---
> packages.gradle | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/packages.gradle b/packages.gradle
> index c00efc6..f6b8543 100644
> --- a/packages.gradle
> +++ b/packages.gradle
> @@ -302,6 +302,7 @@ def genTasks = { target ->
> --preserve-envvar MAVEN3_HOME \
> --preserve-envvar MAVEN_OPTS \
> --preserve-envvar JAVA_HOME \
> +--preserve-envvar BIGTOP_JDK \
> --set-envvar=HADOOP_VERSION=$HADOOP_VERSION \
> --set-envvar=${toOldStyleName(target)}_BASE_VERSION=$BASE_VERSION \
> --set-envvar=${toOldStyleName(target)}_VERSION=$PKG_VERSION \
> --
> 2.1.4