[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #28: [FLINK-26423] Integrate log store to StoreSink

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #28:
URL: https://github.com/apache/flink-table-store/pull/28#discussion_r821301541



##########
File path: flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/sink/CommittableSerializerTest.java
##########
@@ -18,21 +18,74 @@
 
 package org.apache.flink.table.store.connector.sink;
 
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.RowType;
+
 import org.junit.jupiter.api.Test;
 
+import java.io.IOException;
+
+import static org.apache.flink.table.store.file.manifest.ManifestCommittableSerializerTest.randomIncrement;
+import static org.apache.flink.table.store.file.mergetree.compact.CompactManagerTest.row;
 import static org.assertj.core.api.Assertions.assertThat;
 
 /** Test for {@link CommittableSerializer}. */
 public class CommittableSerializerTest {
 
+    private final FileCommittableSerializer fileSerializer =
+            new FileCommittableSerializer(
+                    RowType.of(new IntType()),
+                    RowType.of(new IntType()),
+                    RowType.of(new IntType()));
+
+    private final CommittableSerializer serializer =
+            new CommittableSerializer(fileSerializer, (SimpleVersionedSerializer) fileSerializer);

Review comment:
       Let's use StringCommittableSerializer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org