You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/09/15 01:56:31 UTC
Review Request 62344: Made `Slave::checkDiskUsage` return a `Future`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62344/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-7939
https://issues.apache.org/jira/browse/MESOS-7939
Repository: mesos
Description
-------
With a `Future` returned by `Slave::checkDiskUsage`, we are able to make
certain events (e.g., checkpointing) wait for disk GC to ensure enough
disk space.
Now `Slave::checkDiskUsage` no longer dispatch a subsequent call through
`process::delay` since it only accepts void functions. Instead, we use
`process::loop` to run `Slave::checkDiskUsage` periodically.
Diffs
-----
src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
src/tests/gc_tests.cpp da9a31c30e759e30492963c199da2b16e9f91550
Diff: https://reviews.apache.org/r/62344/diff/1/
Testing
-------
Testing done in r/62336.
Thanks,
Chun-Hung Hsiao
Re: Review Request 62344: Made `Slave::checkDiskUsage` return a
`Future`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62344/#review185467
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62252', '62230', '62343', '62344']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62344
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62344/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (276 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (286 ms)
[----------] 30 tests from ContentType/SchedulerTest (26938 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (1312 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1031 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2465 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (136 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (155 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (339 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (354766 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62344/logs/mesos-tests-stderr.log):
```
I0915 03:45:17.291621 18116 master.cpp:8418] Removing framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (default)
I0915 03:45:17.296263 18116 master.cpp:3267] Deactivating framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (default)
I0915 03:45:17.296619 18116 master.cpp:8993] Updating the state of task b061744a-1788-4bb5-81de-209b814bbc4f of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0915 03:45:17.296619 17676 slave.cpp:3240] Shutting down framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000
I0915 03:45:17.297621 18304 hierarchical.cpp:412] Deactivated framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000
I0915 03:45:17.300621 18116 master.cpp:9087] Removing task b061744a-1788-4bb5-81de-209b814bbc4f with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 on agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 03:45:17.310657 17676 slave.cpp:5736] Shutting down executor 'default' of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (via HTTP)
I0915 03:45:17.312620 18116 master.cpp:9116] Removing executor 'default' with resources [] of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 on agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 03:45:17.328620 17676 hierarchical.cpp:355] Removed framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000
E0915 03:45:17.329620 18304 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0915 03:45:17.330621 18404 scheduler.cpp:444] Re-detecting master
I0915 03:45:17.333621 18404 scheduler.cpp:470] New master detected at master@10.3.1.5:59561
I0915 03:45:17.345621 18116 slave.cpp:5412] Executor 'default' of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 exited with status 0
I0915 03:45:17.346621 18116 slave.cpp:5516] Cleaning up executor 'default' of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (via HTTP)
W0915 03:45:17.346621 18420 master.cpp:7021] Ignoring unknown exited executor 'default' of framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000 on agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 03:45:17.350858 17676 gc.cpp:93] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\N8NwuT\slaves\c880e0d2-9c48-4917-8869-40f29b2cd664-S0\frameworks\c880e0d2-9c48-4917-8869-40f29b2cd664-0000\executors\default\runs\afe83c49-f323-4a45-9880-111d1c0d65d9' for gc 6.99999598817185days in the future
I0915 03:45:17.353626 18116 slave.cpp:5612] Cleaning up framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000
I0915 03:45:17.356678 18404 status_update_manager.cpp:285] Closing status update streams for framework c880e0d2-9c48-4917-8869-40f29b2cd664-0000
I0915 03:45:17.356678 17676 gc.cpp:93] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\N8NwuT\slaves\c880e0d2-9c48-4917-8869-40f29b2cd664-S0\frameworks\c880e0d2-9c48-4917-8869-40f29b2cd664-0000\executors\default' for gc 6.99999591864593days in the future
I0915 03:45:17.358621 18116 slave.cpp:866] Agent terminating
I0915 03:45:17.358621 17676 gc.cpp:93] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\N8NwuT\slaves\c880e0d2-9c48-4917-8869-40f29b2cd664-S0\frameworks\c880e0d2-9c48-4917-8869-40f29b2cd664-0000' for gc 6.99999586084444days in the future
I0915 03:45:17.359622 18356 master.cpp:1321] Agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0915 03:45:17.373035 18356 master.cpp:3304] Disconnecting agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 03:45:17.373102 18356 master.cpp:3323] Deactivating agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 at slave(254)@10.3.1.5:59561 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0915 03:45:17.373621 17676 hierarchical.cpp:690] Agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0 deactivated
I0915 03:45:17.390621 17276 master.cpp:1163] Master terminating
I0915 03:45:17.398944 18304 hierarchical.cpp:626] Removed agent c880e0d2-9c48-4917-8869-40f29b2cd664-S0
W0915 03:45:17.403621 17276 master.hpp:2761] Failed to close HTTP pipe for c880e0d2-9c48-4917-8869-40f29b2cd664-0000 (default)
I0915 03:45:18.177633 14900 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 15, 2017, 1:56 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62344/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 1:56 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7939
> https://issues.apache.org/jira/browse/MESOS-7939
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With a `Future` returned by `Slave::checkDiskUsage`, we are able to make
> certain events (e.g., checkpointing) wait for disk GC to ensure enough
> disk space.
>
> Now `Slave::checkDiskUsage` no longer dispatch a subsequent call through
> `process::delay` since it only accepts void functions. Instead, we use
> `process::loop` to run `Slave::checkDiskUsage` periodically.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094
> src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
> src/tests/gc_tests.cpp da9a31c30e759e30492963c199da2b16e9f91550
>
>
> Diff: https://reviews.apache.org/r/62344/diff/1/
>
>
> Testing
> -------
>
> Testing done in r/62336.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>