You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/10 22:54:00 UTC

[jira] [Commented] (CB-14125) Increase cordova-android old plugin compatibility

    [ https://issues.apache.org/jira/browse/CB-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507527#comment-16507527 ] 

ASF GitHub Bot commented on CB-14125:
-------------------------------------

jcesarmobile opened a new pull request #449: CB-14125:(android) Increase old plugin compatibility
URL: https://github.com/apache/cordova-android/pull/449
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   Increases old plugin compatibility by adding 'app/src/main' to all plugin source-file tags that didn't include it, so the files are copied to the new Android Studio structure
   
   ### What testing has been done on this change?
   Tested with `cordova plugin add https://github.com/OutSystems/cordova-plugin-audiorecorder.git` as it uses source-file for images and xml
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Increase cordova-android old plugin compatibility
> -------------------------------------------------
>
>                 Key: CB-14125
>                 URL: https://issues.apache.org/jira/browse/CB-14125
>             Project: Apache Cordova
>          Issue Type: Improvement
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>            Priority: Major
>
> With the structure change of cordova-android 7.1.0, a lot of plugins don't work because they user source-file tag for images or other file types.
> Right now, we only patch to the new path structure .java and .xml files. 
> Add 'app/src/main' to all file types, no mater what type they have.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org