You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:57:01 UTC
[GitHub] [kafka] kowshik opened a new pull request #10797: KAFKA-12867: Fix ConsumeBenchWorker exit behavior for maxMessages config
kowshik opened a new pull request #10797:
URL: https://github.com/apache/kafka/pull/10797
The trogdor `ConsumeBenchWorker` has a bug. If one of the consumption tasks completes executing successfully due to `maxMessages` being consumed, then, the consumption task notifies the `doneFuture` causing the entire `ConsumeBenchWorker` to halt. This becomes a problem when more than 1 consumption task is running in parallel, because the successful completion of 1 of the tasks shuts down the entire worker while the other tasks are still running. When the worker is shut down, it kills all the active consumption tasks, which is not the desired behavior.
The fix is to not notify the `doneFuture` when 1 of the consumption tasks complete without error. Instead, we should defer the notification to the `CloseStatusUpdater` thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram merged pull request #10797: KAFKA-12867: Fix ConsumeBenchWorker exit behavior for maxMessages config
Posted by GitBox <gi...@apache.org>.
rajinisivaram merged pull request #10797:
URL: https://github.com/apache/kafka/pull/10797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #10797: KAFKA-12867: Fix ConsumeBenchWorker exit behavior for maxMessages config
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #10797:
URL: https://github.com/apache/kafka/pull/10797#issuecomment-851293196
cc @junrao @apovzner @rajinisivaram for review.
@apovzner It appears this behavior has been around since `ConsumeBenchWorker` was first implemented: https://github.com/apache/kafka/pull/4775. Please let me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org