You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "shukitchan (via GitHub)" <gi...@apache.org> on 2023/09/25 06:14:48 UTC
[GitHub] [trafficserver] shukitchan opened a new pull request, #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
shukitchan opened a new pull request, #10515:
URL: https://github.com/apache/trafficserver/pull/10515
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan merged pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan merged PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515#issuecomment-1733028108
@serrislew pls take a look. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on a diff in pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on code in PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515#discussion_r1337561523
##########
plugins/experimental/wasm/wasm_main.cc:
##########
@@ -28,6 +28,10 @@
#include "include/proxy-wasm/wasmedge.h"
#endif
+#ifdef WASMTIME
+#include "include/proxy-wasm/wasmtime.h"
Review Comment:
Yup. That's controlled by Makefile.inc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on a diff in pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515#discussion_r1337510194
##########
plugins/experimental/wasm/wasm_main.cc:
##########
@@ -28,6 +28,10 @@
#include "include/proxy-wasm/wasmedge.h"
#endif
+#ifdef WASMTIME
+#include "include/proxy-wasm/wasmtime.h"
Review Comment:
will this have any conflict with WARM above? Or will WASMTIME not be defined if WAMR is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on a diff in pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515#discussion_r1336505018
##########
plugins/experimental/wasm/wasm_main.cc:
##########
@@ -62,23 +66,23 @@ transform_handler(TSCont contp, ats_wasm::TransformInfo *ti)
ats_wasm::Context *c;
- Dbg(dbg_ctl, "[%s] transform handler begins", __FUNCTION__);
+ Dbg(ats_wasm::dbg_ctl, "[%s] transform handler begins", __FUNCTION__);
Review Comment:
would it be more consistent (with the other plugins/definitions) to add `using namespace ats_wasm` instead of explicitly defining the namespace for each debug statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on a diff in pull request #10515: Fix problem with debug and add support for Wasmtime for wasm plugin
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on code in PR #10515:
URL: https://github.com/apache/trafficserver/pull/10515#discussion_r1336539243
##########
plugins/experimental/wasm/wasm_main.cc:
##########
@@ -62,23 +66,23 @@ transform_handler(TSCont contp, ats_wasm::TransformInfo *ti)
ats_wasm::Context *c;
- Dbg(dbg_ctl, "[%s] transform handler begins", __FUNCTION__);
+ Dbg(ats_wasm::dbg_ctl, "[%s] transform handler begins", __FUNCTION__);
Review Comment:
I probably can. But I was just trying to make it consistent inside this file (wasm_main.cc) and not using namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org