You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/03 02:23:53 UTC
[GitHub] [incubator-pinot] npawar commented on issue #4602: First pass of
GROUP BY with ORDER BY support
npawar commented on issue #4602: First pass of GROUP BY with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-537757804
> Also, for the benchmark number, why for several cases TOP 15k is faster than TOP 5k, which is then faster than TOP 500?
The code used in benchmark decided `capacity` and `bufferCapacity` entirely on the basis of `TOP`. Capacity = Max(5 * TOP, 5k). As a result, more the TOP, lesser the number of resizes. That's why as TOP increased the performance improved.
It has been since changed, to just have a very large `capacity`. We will focus on the optimization of resize after this PR is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org