You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/20 13:15:02 UTC
[GitHub] [spark] attilapiros opened a new pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
attilapiros opened a new pull request #29492:
URL: https://github.com/apache/spark/pull/29492
### What changes were proposed in this pull request?
Removing the individual `close` method calls on the pooled `TransportClient` instances.
The pooled clients should be only closed via `TransportClientFactory#close()`.
### Why are the changes needed?
Reusing a closed `TransportClient` leads to the exception `java.nio.channels.ClosedChannelException`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a trivial case which is not tested by specific test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677774811
**[Test build #127694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127694/testReport)** for PR 29492 at commit [`02375d7`](https://github.com/apache/spark/commit/02375d72f3829399b615f894666f23155d6abd8a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677776087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677659797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] otterc commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
otterc commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677827211
Looks good to me. Thanks @attilapiros
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677695266
Looks good to me, will wait for tests to pass.
+CC @vanzin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-678001245
Looks right to me too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677776087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677659128
**[Test build #127694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127694/testReport)** for PR 29492 at commit [`02375d7`](https://github.com/apache/spark/commit/02375d72f3829399b615f894666f23155d6abd8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677659128
**[Test build #127694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127694/testReport)** for PR 29492 at commit [`02375d7`](https://github.com/apache/spark/commit/02375d72f3829399b615f894666f23155d6abd8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-677659797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #29492:
URL: https://github.com/apache/spark/pull/29492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #29492: [SPARK-32663][CORE] Avoid individual closing of pooled TransportClients (which must be closed through the pool)
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #29492:
URL: https://github.com/apache/spark/pull/29492#issuecomment-678059350
Thanks for the fix @attilapiros ! Merged to master and branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org