[jira] [Commented] (HBASE-14100) Fix high priority findbugs warnings

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629672#comment-14629672 ] 

Duo Zhang commented on HBASE-14100:
-----------------------------------

{{DMI_INVOKING_TOSTRING_ON_ARRAY}}

{code:title=SplitLogManager.java}
300         FileStatus[] files = fs.listStatus(logDir);
301         if (files != null && files.length > 0) {
302           LOG.warn("Returning success without actually splitting and "
303               + "deleting all the log files in path " + logDir + ": " + files, ioe); // files is an array, should we use Arrays.toString here? Is it too noisy?
304         } else {
305           LOG.warn("Unable to delete log src dir. Ignoring. " + logDir, ioe);
306         }
{code}

{code:title=SimpleRegionNormalizer.java}
152       LOG.debug("Table " + table + ", largest region "
153         + largestRegion.getFirst().getRegionName() + " has size " // Should be getRegionNameAsString()?
154         + largestRegion.getSecond() + ", more than 2 times than avg size, splitting");
{code}

> Fix high priority findbugs warnings
> -----------------------------------
>
>                 Key: HBASE-14100
>                 URL: https://issues.apache.org/jira/browse/HBASE-14100
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>
> See here:
> https://builds.apache.org/job/HBase-TRUNK/6654/findbugsResult/HIGH/
> We have 6 high priority findbugs warnings. A high priority findbugs warning is usually a bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)