You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2016/02/13 15:08:01 UTC

[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/854#discussion_r52828211
  
    --- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
    @@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL);
     BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)
     #endif
     
    -BOOST_FIXTURE_TEST_SUITE(TSSLSocketInterruptTest, TestPortFixture)
    --- End diff --
    
    Can you keep 3 of these as BOOST_**AUTO**_TEST_SUITE ?
    
    This would remove a namespace and put everything into global namespace.
    In this regard, it seems that this one should have been placed before the `keyDir` symbol already...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---