You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/07 21:38:05 UTC
[GitHub] [netbeans] hectorespert opened a new pull request #2744: Options panel use GTK default colors
hectorespert opened a new pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744
Use default colors in options panel when GTK laf is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-885510270
change resquested moving to 12.6 for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-812887631
> A step in the good direction, though if we are adding new LAF keys, probably shall add constants for it in LFCustoms.
I added the new constants in LFCustoms.
> And by introducing that it would be good to check if all supported LAF-s are providing defaults for the new key.
New keys are only used by GTK theme, I would like to fix the problem with that theme before start to modify the other themes.
> A sidenote: It would be really great if you could detect somehow when the GTK skin is set to dark, if it does, it would be great at least add the `"nb.dark.theme"` to true.
A GTK configuration property to detect that is available: https://developer.gnome.org/gtk3/3.8/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#discussion_r673940750
##########
File path: platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/LFCustoms.java
##########
@@ -423,4 +423,11 @@ private void disposeValues (Object[] arr) {
public static final String PROGRESS_CANCEL_BUTTON_ICON = "nb.progress.cancel.icon";
public static final String PROGRESS_CANCEL_BUTTON_ROLLOVER_ICON = "nb.progress.cancel.icon.mouseover";
public static final String PROGRESS_CANCEL_BUTTON_PRESSED_ICON = "nb.progress.cancel.icon.pressed";
+
+ /**
+ * Keys used by the options dialog module.
+ */
+ protected static final String OPTIONS_USE_UI_DEFAULT_COLORS = "Nb.options.useUIDefaultsColors";
Review comment:
Why protected instead of public?
"Nb" or "nb"? Yes I've seen both prefixes, however it would be good to stick with "nb.options"
##########
File path: platform/options.api/src/org/netbeans/modules/options/OptionsPanel.java
##########
@@ -877,7 +869,7 @@ private void addCategoryButtons () {
private CategoryButton addButton (CategoryModel.Category category) {
int index = buttons.size ();
- CategoryButton button = isNimbus || isGTK
+ CategoryButton button = UIManager.getBoolean("Nb.options.categories.button.useNimbusCategoryButton") //NOI18N
Review comment:
Would be nicer to reintroduce the same constants as in LFCustoms at the top of the file again (now it can be not public)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#discussion_r730242748
##########
File path: platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/LFCustoms.java
##########
@@ -423,4 +423,11 @@ private void disposeValues (Object[] arr) {
public static final String PROGRESS_CANCEL_BUTTON_ICON = "nb.progress.cancel.icon";
public static final String PROGRESS_CANCEL_BUTTON_ROLLOVER_ICON = "nb.progress.cancel.icon.mouseover";
public static final String PROGRESS_CANCEL_BUTTON_PRESSED_ICON = "nb.progress.cancel.icon.pressed";
+
+ /**
+ * Keys used by the options dialog module.
+ */
+ protected static final String OPTIONS_USE_UI_DEFAULT_COLORS = "Nb.options.useUIDefaultsColors";
Review comment:
Constants changed to public and use "nb" prefix instead "Nb"
##########
File path: platform/options.api/src/org/netbeans/modules/options/OptionsPanel.java
##########
@@ -877,7 +869,7 @@ private void addCategoryButtons () {
private CategoryButton addButton (CategoryModel.Category category) {
int index = buttons.size ();
- CategoryButton button = isNimbus || isGTK
+ CategoryButton button = UIManager.getBoolean("Nb.options.categories.button.useNimbusCategoryButton") //NOI18N
Review comment:
Constants added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-884151069
@neilcsmith-net @lkishalmi are the changes better now ? Can we consider merging ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-779377540
Sorry, -1 from me on this. Although +1 to fixing it. We can't keep adding exceptions for look and feels over the code base. Better to fix this so that a single key works for all LAFs. If `separator.foreground` doesn't work for all, maybe a specific key for this panel that does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-997187383
> Any reason not to merge now?
It's only waiting for a positive review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-997050946
This seems to be a working implementation, which even looks like a cleanup. Any reason not to merge now? (the unittests that fail are known to be flaky).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-946624155
@lkishalmi please review and merge if you're happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-821070261
Changing milestone to 12.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-803400671
A step in the good direction, though if we are adding new LAF keys, probably shall add constants for it in LFCustoms.
And by introducing that it would be good to check if all supported LAF-s are providing defaults for the new key.
A sidenote: It would be really great if you could detect somehow when the GTK skin is set to dark, if it does, it would be great at least add the ```"nb.dark.theme"``` to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2744: Options panel use GTK default colors
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#issuecomment-784530991
> Sorry, -1 from me on this. Although +1 to fixing it. We can't keep adding exceptions for look and feels over the code base. Better to fix this so that a single key works for all LAFs. If `separator.foreground` doesn't work for all, maybe a specific key for this panel that does?
I added a keys to modify this panel to allow remove LAFs exceptions but this PR only removes exceptions for the GTK laf.
I can't test other LAFs and they could be modified later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists