You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Felix Schumacher <fe...@internetallee.de> on 2016/11/13 12:45:29 UTC
Re: svn commit: r1769411 -
/jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
Am 12.11.2016 21:29, schrieb pmouawad@apache.org:
> Author: pmouawad
> Date: Sat Nov 12 20:29:20 2016
> New Revision: 1769411
>
> URL: http://svn.apache.org/viewvc?rev=1769411&view=rev
> Log:
> Sync on final field
>
> Modified:
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>
> Modified:
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java?rev=1769411&r1=1769410&r2=1769411&view=diff
> ==============================================================================
> ---
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
> (original)
> +++
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
> Sat Nov 12 20:29:20 2016
> @@ -106,7 +106,7 @@ public class TableVisualizer extends Abs
>
> private JCheckBox childSamples = null;
>
> - private transient Calculator calc = new Calculator();
> + private final transient Calculator calc = new Calculator();
I don't think that "final transient" is a valid combination of
modifiers.
Regards,
Felix
>
> private Format format = new SimpleDateFormat("HH:mm:ss.SSS");
> //$NON-NLS-1$
Re: svn commit: r1769411 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Yes sync on a new object is better.
Note this wrong combination is present in code at many places.
Regards
On Sun, Nov 13, 2016 at 1:47 PM, sebb <se...@gmail.com> wrote:
> Might be better to synch on a separate Object e.g.:
>
> private final Object LOCK = new Object();
>
> On 13 November 2016 at 12:45, Felix Schumacher
> <fe...@internetallee.de> wrote:
> > Am 12.11.2016 21:29, schrieb pmouawad@apache.org:
> >>
> >> Author: pmouawad
> >> Date: Sat Nov 12 20:29:20 2016
> >> New Revision: 1769411
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1769411&view=rev
> >> Log:
> >> Sync on final field
> >>
> >> Modified:
> >>
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >>
> >> Modified:
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> URL:
> >>
> >> http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> org/apache/jmeter/visualizers/TableVisualizer.java?rev=
> 1769411&r1=1769410&r2=1769411&view=diff
> >>
> >> ============================================================
> ==================
> >> ---
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> (original)
> >> +++
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> Sat Nov 12 20:29:20 2016
> >> @@ -106,7 +106,7 @@ public class TableVisualizer extends Abs
> >>
> >> private JCheckBox childSamples = null;
> >>
> >> - private transient Calculator calc = new Calculator();
> >> + private final transient Calculator calc = new Calculator();
> >
> >
> > I don't think that "final transient" is a valid combination of modifiers.
> >
> >
> > Regards,
> > Felix
> >
> >>
> >> private Format format = new SimpleDateFormat("HH:mm:ss.SSS");
> >> //$NON-NLS-1$
>
--
Cordialement.
Philippe Mouawad.
Re: svn commit: r1769411 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
Posted by sebb <se...@gmail.com>.
Might be better to synch on a separate Object e.g.:
private final Object LOCK = new Object();
On 13 November 2016 at 12:45, Felix Schumacher
<fe...@internetallee.de> wrote:
> Am 12.11.2016 21:29, schrieb pmouawad@apache.org:
>>
>> Author: pmouawad
>> Date: Sat Nov 12 20:29:20 2016
>> New Revision: 1769411
>>
>> URL: http://svn.apache.org/viewvc?rev=1769411&view=rev
>> Log:
>> Sync on final field
>>
>> Modified:
>>
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>>
>> Modified:
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> URL:
>>
>> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java?rev=1769411&r1=1769410&r2=1769411&view=diff
>>
>> ==============================================================================
>> ---
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> (original)
>> +++
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> Sat Nov 12 20:29:20 2016
>> @@ -106,7 +106,7 @@ public class TableVisualizer extends Abs
>>
>> private JCheckBox childSamples = null;
>>
>> - private transient Calculator calc = new Calculator();
>> + private final transient Calculator calc = new Calculator();
>
>
> I don't think that "final transient" is a valid combination of modifiers.
>
>
> Regards,
> Felix
>
>>
>> private Format format = new SimpleDateFormat("HH:mm:ss.SSS");
>> //$NON-NLS-1$