You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/23 20:56:26 UTC

[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair

adelapena commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r493889993



##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
     with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
         yield
 
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):

Review comment:
       @maedhroz Yes, we initially did a literal migration of this class that we discarded because we considered that the tested cases were already covered by the existing tests. However, just removing this class feels a bit scary to me, perhaps we could keep it around by now with a deprecation note, WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org