[GitHub] [airflow] bbovenzi commented on a diff in pull request #30950: Adding keyboard shortcuts to common actions

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi commented on code in PR #30950:
URL: https://github.com/apache/airflow/pull/30950#discussion_r1182870521


##########
airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx:
##########
@@ -77,6 +78,10 @@ const ClearInstance = ({
   const [failed, setFailed] = useState(false);
   const onToggleFailed = () => setFailed(!failed);
 
+  const initialClearButtonFocusRef = useRef<HTMLButtonElement>(null);
+
+  useKeysPress("shiftKey", ['c', 'C'], onOpen);

Review Comment:
   Cool! Do you have a list of what shortcuts you want to do? We'll need to check this across browsers or toggle on/off if it conflicts with a user's shortcuts for something else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org