[GitHub] [incubator-dolphinscheduler] gabrywu commented on a change in pull request #3427: [Feature][server,api,common,dao,remote] delay execution of tasks and improve some designs

[GitBox <gi...@apache.org>]

gabrywu commented on a change in pull request #3427:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3427#discussion_r468296180



##########
File path: dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/codec/NettyDecoder.java
##########
@@ -55,15 +55,18 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) t
             case MAGIC:
                 checkMagic(in.readByte());
                 checkpoint(State.COMMAND);
+                break;
             case COMMAND:
                 commandHeader.setType(in.readByte());
                 checkpoint(State.OPAQUE);
+                break;
             case OPAQUE:
                 commandHeader.setOpaque(in.readLong());
                 checkpoint(State.BODY_LENGTH);
             case BODY_LENGTH:
                 commandHeader.setBodyLength(in.readInt());
                 checkpoint(State.BODY);
+                break;

Review comment:
       Of course, you can add a break at the last case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org