[GitHub] [cassandra] maedhroz commented on a change in pull request #1501: CASSANDRA-17424 Performance and Semantic Concerns w/ Metrics for Local vs. Remote Requests in StorageProxy

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1501:
URL: https://github.com/apache/cassandra/pull/1501#discussion_r826431380



##########
File path: src/java/org/apache/cassandra/service/StorageProxy.java
##########
@@ -1027,11 +1011,6 @@ public static void mutateMV(ByteBuffer dataKey, Collection<Mutation> mutations,
                 // add a handler for each mutation - includes checking availability, but doesn't initiate any writes, yet
                 for (Mutation mutation : mutations)
                 {
-                    if (hasLocalMutation(mutation))
-                        writeMetrics.localRequests.mark();
-                    else
-                        writeMetrics.remoteRequests.mark();
-

Review comment:
       This codepath seems to be actuated by writes on the MV's base table, so it didn't seem correct to record anything around these metrics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org