[GitHub] spark pull request #22514: [SPARK-25271][SQL] Hive ctas commands should use ...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22514#discussion_r225079174
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
    @@ -34,11 +34,16 @@ import org.apache.spark.sql.types._
      * @param tableDesc the metadata of the table to be created.
      * @param mode the data writing mode
      * @param query an optional logical plan representing data to write into the created table.
    + * @param useExternalSerde whether to use external serde to write data, e.g., Hive Serde. Currently
    --- End diff --
    
    This is too hacky. We should not leak hive specific knowledge to general logical plans.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org