You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/20 09:39:57 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request, #6306: Add up_textheap_heapmember

yamt opened a new pull request, #6306:
URL: https://github.com/apache/incubator-nuttx/pull/6306

   ## Summary
   intended usage: https://github.com/bytecodealliance/wasm-micro-runtime/pull/1181
   
   ## Impact
   
   ## Testing
   tested on esp32 (with various other patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] yamt commented on pull request #6306: Add up_textheap_heapmember

Posted by GitBox <gi...@apache.org>.
yamt commented on PR #6306:
URL: https://github.com/apache/incubator-nuttx/pull/6306#issuecomment-1132805828

   > LGTM!
   > 
   > Although [bytecodealliance/wasm-micro-runtime#1181](https://github.com/bytecodealliance/wasm-micro-runtime/pull/1181) calls directly into arch code. We briefly discussed this before, and some ideas where `mallopt` and maybe also `PROT_EXEC` for `mmap`.
   
   where was it discussed? i agree something more generic is nicer.
   
   i considered to fix mmap. but it involves unnecessary overhead for this particular application.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6306: Add up_textheap_heapmember

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6306:
URL: https://github.com/apache/incubator-nuttx/pull/6306


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6306: Add up_textheap_heapmember

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6306:
URL: https://github.com/apache/incubator-nuttx/pull/6306#issuecomment-1132822783

   > > LGTM!
   > > Although [bytecodealliance/wasm-micro-runtime#1181](https://github.com/bytecodealliance/wasm-micro-runtime/pull/1181) calls directly into arch code. We briefly discussed this before, and some ideas where `mallopt` and maybe also `PROT_EXEC` for `mmap`.
   > 
   > where was it discussed? i agree something more generic is nicer.
   > 
   > i considered to fix mmap. but it involves unnecessary overhead for this particular application.
   
   Just internally, given the different regions ESP32 has.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org