You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by hu...@apache.org on 2019/06/24 18:20:01 UTC
[helix.wiki] branch master updated: Updated Pull Request Guidelines
(markdown)
This is an automated email from the ASF dual-hosted git repository.
hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new 7850ed4 Updated Pull Request Guidelines (markdown)
7850ed4 is described below
commit 7850ed4689eb4559d844586248f3d1073fdeb953
Author: Hunter Lee <na...@gmail.com>
AuthorDate: Mon Jun 24 11:19:59 2019 -0700
Updated Pull Request Guidelines (markdown)
---
Pull-Request-Guidelines.md | 40 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/Pull-Request-Guidelines.md b/Pull-Request-Guidelines.md
index d3da6b1..03b3c3a 100644
--- a/Pull-Request-Guidelines.md
+++ b/Pull-Request-Guidelines.md
@@ -6,4 +6,42 @@ Before you submit a pull request from your forked repo, check that it meets thes
* Please [rebase your fork](https://stackoverflow.com/questions/7244321/how-do-i-update-a-github-forked-repository/7244456#7244456), squash commits, and resolve all conflicts.
* Every pull request should have an associated issue. The issue must be linked in the PR description.
* Add an [Apache License header](http://www.apache.org/legal/src-headers.html) to all new files
-* If the pull request adds functionality, please add a corresponding wiki page detailing the motivation and use of the feature.
\ No newline at end of file
+* If the pull request adds functionality, please add a corresponding wiki page detailing the motivation and use of the feature.
+
+# Every pull request must contain the following:
+
+### Issues
+
+- [ ] My PR addresses the following Helix issues and references them in the PR title:
+
+(#200 - Link your issue number here)
+
+### Description
+
+- [ ] Here are some details about my PR, including screenshots of any UI changes:
+
+(Write a concise description including what, why, how)
+
+### Tests
+
+- [ ] The following tests are written for this issue:
+
+(List the names of added unit/integration tests)
+
+- [ ] The following is the result of the "mvn test" command on the appropriate module:
+
+(Copy & paste the result of "mvn test")
+
+### Commits
+
+- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "_How to write a good git commit message_":
+
+### Documentation
+
+- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
+
+(Link the GitHub wiki you added)
+
+### Code Quality
+
+- [ ] My diff has been formatted using helix-style.xml
\ No newline at end of file