You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/09 11:32:57 UTC

[GitHub] [camel-k] apupier opened a new issue #1599: Fix generation of traits.yaml file

apupier opened a new issue #1599:
URL: https://github.com/apache/camel-k/issues/1599


   typo like this one https://github.com/apache/camel-k/pull/1598 occured during generation
   
   @astefanutti Can you provide more details please?
   Where is the algorithm used for generation?
   Where is the root text?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on issue #1599: Fix generation of traits.yaml file

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1599:
URL: https://github.com/apache/camel-k/issues/1599#issuecomment-656088438


   > @astefanutti Can you provide more details please?
   
   Sure. The description is built from the trait comments. Each comment line is concatenated into a single line string, irrespective of the original text flow. A simple fix could be to add a space character when joining the comment lines. A better fix could be to generate multi-line strings in the output Yaml file, preserving the original flow from the trait authors.
   
   > Where is the algorithm used for generation?
   
   The code path starts from `script/gen_doc.sh` all the way done to: https://github.com/apache/camel-k/blob/ff29575de82a5dc05b4b68512b6da2348c8453d8/cmd/util/doc-gen/generators/traitmetadatagen.go#L127
   
   > Where is the root text?
   
   The metadata are taken directly from the traits source code.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti closed issue #1599: Fix generation of traits.yaml file

Posted by GitBox <gi...@apache.org>.
astefanutti closed issue #1599:
URL: https://github.com/apache/camel-k/issues/1599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on issue #1599: Fix generation of traits.yaml file

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1599:
URL: https://github.com/apache/camel-k/issues/1599#issuecomment-656088438


   > @astefanutti Can you provide more details please?
   
   Sure
   
   > Where is the algorithm used for generation?
   
   The code path starts from `script/gen_doc.sh` all the way done to: https://github.com/apache/camel-k/blob/ff29575de82a5dc05b4b68512b6da2348c8453d8/cmd/util/doc-gen/generators/traitmetadatagen.go#L127
   
   > Where is the root text?
   
   The metadata are taken directly from the traits source code.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on issue #1599: Fix generation of traits.yaml file

Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1599:
URL: https://github.com/apache/camel-k/issues/1599#issuecomment-656088438


   > @astefanutti Can you provide more details please?
   
   Sure
   
   > Where is the algorithm used for generation?
   
   The code path starts from `script/gen_doc.sh` all the way done to https://github.com/apache/camel-k/blob/ff29575de82a5dc05b4b68512b6da2348c8453d8/cmd/util/doc-gen/generators/traitmetadatagen.go#L127
   
   > Where is the root text?
   
   The metadata are taken directly from the traits source code.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org