[GitHub] [incubator-superset] michellethomas opened a new pull request #7242: Fix race condition when fetching results in SQL Lab (#7198)

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #7242: Fix race condition when fetching results in SQL Lab (#7198)
URL: https://github.com/apache/incubator-superset/pull/7242
 
 
   * Fix race condition when fetching results in SQL Lab
   
   * Fix lint
   
   (cherry picked from commit ca6a73b028a1954c8e8d1dfa077bc7ee0a2694c0)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
     http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   ##### SUMMARY
   Cherry picking change that got into lyftga and is impacting superset users running sql queries. Queries get to 100% and don't return results because the query is marked as successful but has no `resultsKey`.
   
   ##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ##### TEST PLAN
   Run multiple queries in a row with large payloads
   Confirm that they hit 100% and return results
   
   ##### ADDITIONAL INFORMATION
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> 
   <!--- Check any relevant boxes with "x" -->
       [ ] Has associated issue:
       [ ] Changes UI
       [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
       [ ] Introduces new feature or API
       [ ] Removes existing feature or API
       [x] Fixes bug
       [ ] Refactors code
       [ ] Adds test(s)
   
   ##### REVIEWERS
   @john-bodley @graceguo-supercat @betodealmeida @xtinec 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org