You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "mmodzelewski (via GitHub)" <gi...@apache.org> on 2026/03/10 09:28:09 UTC
[PR] refactor(java): use generation-based auth for pooled channels [iggy]
mmodzelewski opened a new pull request, #2910:
URL: https://github.com/apache/iggy/pull/2910
Pooled connections authenticated with a simple boolean flag
failed to re-authenticate after logout/re-login cycles.
Channels from the prior session appeared authenticated but
held stale server-side state, causing silent failures.
Replace the boolean auth attribute with an AtomicLong
generation counter. Each login increments the generation;
logout invalidates all channels by advancing it. Channels
compare their stored generation on acquire and transparently
re-authenticate when stale.
Additional cleanup: move pool initialization into the
constructor with eager connectivity validation, extract
PoolChannelHandler as a static inner class, fix payload
leak on acquire failure by releasing in finally, fix
login capture to include PAT login (was incorrectly
capturing UPDATE), reduce IggyAuthenticator/FrameEncoder
visibility to package-private, and migrate to Netty 5
IoEventLoopGroup API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(java): use generation-based auth for pooled channels [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2910:
URL: https://github.com/apache/iggy/pull/2910#issuecomment-4030169120
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2910?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `72.82609%` with `25 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 70.41%. Comparing base ([`0625ba9`](https://app.codecov.io/gh/apache/iggy/commit/0625ba95585c8e006a22f342d8006905696e6629?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e8eb8ed`](https://app.codecov.io/gh/apache/iggy/commit/e8eb8ed0ba719aa3908c10218e3dec55a85052f7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/iggy/client/async/tcp/AsyncTcpConnection.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FAsyncTcpConnection.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvQXN5bmNUY3BDb25uZWN0aW9uLmphdmE=) | 72.36% | [15 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/iggy/client/async/tcp/IggyAuthenticator.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FIggyAuthenticator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvSWdneUF1dGhlbnRpY2F0b3IuamF2YQ==) | 80.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/iggy/client/async/tcp/IggyFrameEncoder.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FIggyFrameEncoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvSWdneUZyYW1lRW5jb2Rlci5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2910 +/- ##
============================================
+ Coverage 70.40% 70.41% +0.01%
- Complexity 763 772 +9
============================================
Files 1041 1041
Lines 86435 86437 +2
Branches 62710 62707 -3
============================================
+ Hits 60854 60865 +11
+ Misses 23060 23052 -8
+ Partials 2521 2520 -1
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2910/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/iggy/pull/2910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.65% <72.82%> (+0.49%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/iggy/client/async/tcp/AsyncIggyTcpClient.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FAsyncIggyTcpClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvQXN5bmNJZ2d5VGNwQ2xpZW50LmphdmE=) | `98.48% <ø> (ø)` | |
| [...pache/iggy/client/async/tcp/IggyAuthenticator.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FIggyAuthenticator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvSWdneUF1dGhlbnRpY2F0b3IuamF2YQ==) | `85.18% <80.00%> (+9.18%)` | :arrow_up: |
| [...apache/iggy/client/async/tcp/IggyFrameEncoder.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FIggyFrameEncoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvSWdneUZyYW1lRW5jb2Rlci5qYXZh) | `40.00% <66.66%> (-5.00%)` | :arrow_down: |
| [...ache/iggy/client/async/tcp/AsyncTcpConnection.java](https://app.codecov.io/gh/apache/iggy/pull/2910?src=pr&el=tree&filepath=foreign%2Fjava%2Fjava-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Figgy%2Fclient%2Fasync%2Ftcp%2FAsyncTcpConnection.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9qYXZhL2phdmEtc2RrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pZ2d5L2NsaWVudC9hc3luYy90Y3AvQXN5bmNUY3BDb25uZWN0aW9uLmphdmE=) | `69.75% <72.36%> (+4.39%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2910/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(java): use generation-based auth for pooled channels [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #2910:
URL: https://github.com/apache/iggy/pull/2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org