You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "joshartman (via GitHub)" <gi...@apache.org> on 2023/04/30 12:44:07 UTC

[GitHub] [qpid-protonj2] joshartman commented on a diff in pull request #6: When using RabbitMQ, the virtualHost API call was ignored.

joshartman commented on code in PR #6:
URL: https://github.com/apache/qpid-protonj2/pull/6#discussion_r1181225346


##########
protonj2-client/src/main/java/org/apache/qpid/protonj2/client/impl/ClientConnection.java:
##########
@@ -886,10 +886,11 @@ private void initializeProtonResources(ReconnectLocation location) throws Client
             protonConnection.setContainerId(connectionId);
         }
 
+        final String hostname = (options.virtualHost() == null || options.virtualHost().length() < 1) ? location.getHost() : options.virtualHost();

Review Comment:
   Code updated as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org