[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #3992: Fixing type casting issue for BYTES type values during realtime segment persistence
URL: https://github.com/apache/incubator-pinot/pull/3992#discussion_r267490711
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/stats/RealtimeColumnStatistics.java
 ##########
 @@ -139,6 +140,11 @@ public boolean isSorted() {
       return false;
     }
 
+    // Values in BYTES are not comparable
+    if(_block.getMetadata().getDataType().getStoredType() == DataType.BYTES) {
 
 Review comment:
   +1 on using this wrapper comparable. Can we have byte[] column that is sortable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org