You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 05:45:36 UTC

[GitHub] [airflow] timhealz commented on pull request #8849: Add multiple file upload functionality to GCS hook

timhealz commented on pull request #8849:
URL: https://github.com/apache/airflow/pull/8849#issuecomment-628400819


   @mik-laj @turbaszek how about instead of creating a new `upload_multiple` method in the hook, we have the `local_to_gcs.py` operator call the `GCSHook.upload` method one or multiple times based on what is inputted. 
   
   Check out the lastest commit for implementation. This leaves `gcs_hook.py` unchanged from master. I've also moved the tests from the hook to the operator, and added a negative test.
   
   Let me know what you think, I think this makes things simpler, but I can also implement the `upload_multiple` method if we decide that this is not a good idea.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org